[R20-329] campaign feedback - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

18 stars 13 forks source link

[R20-329] campaign feedback #1213

Closed lambry closed 1 month ago

lambry commented 1 month ago

Issue: https://digital-vic.atlassian.net/browse/R20-329

What I did

The original implementation used flex box, but things didn't quite fit 'the grid' exactly, and the CSS wasn't super maintainable, so for CSS simplicity and design accuracy this removes all that in favor of our grid classes.

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	3f273569d0777e99779485b5b5e5603cb1e80544
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/6662805b58aff0000860019a

cypress[bot] commented 1 month ago

Passing run #1885 ↗︎

0

162

0

0

0

Details:

Merge branch 'develop' into feature/campaign-feedback
Project: ripple-framework	Commit: `3f273569d0`
Status: Passed	Duration: 06:37 💡
Started: Jun 7, 2024 3:39 AM	Ended: Jun 7, 2024 3:46 AM

Review all test suite changes for PR #1213 ↗︎