[R20-2040] sort options aria label - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

20 stars 13 forks source link

[R20-2040] sort options aria label #1216

Closed lambry closed 3 months ago

lambry commented 3 months ago

Issue: https://digital-vic.atlassian.net/browse/R20-2040

What I did

Fix sort options aria label, for doesn't work for non labelable elements like our custom dropdown

Before

before

After

after

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

cypress[bot] commented 3 months ago

Passing run #1893 ↗︎

0

162

0

0

0

Details:

fix(@dpc-sdp/ripple-tide-search): fix sort options aria label
Project: ripple-framework	Commit: `e08dc8aad7`
Status: Passed	Duration: 07:43 💡
Started: Jun 12, 2024 1:18 AM	Ended: Jun 12, 2024 1:26 AM

Review all test suite changes for PR #1216 ↗︎

netlify[bot] commented 3 months ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	e08dc8aad75f279b08509b95c41759456c7e09a2
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/6668f93044d1df000862a38c