dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
Apache License 2.0
18 stars 13 forks source link

[WIP] Added support for vector vicmap basemaps #1219

Open jeffdowdle opened 1 month ago

jeffdowdle commented 1 month ago

Still some performance issues when zooming into melbourne CBD, also the map can get crowded with house numbers. Screenshot 2024-06-13 at 1 37 58 pm Screenshot 2024-06-13 at 1 38 28 pm Screenshot 2024-06-13 at 1 38 07 pm Screenshot 2024-06-13 at 1 18 16 pm

Issue:

What I did

How to test

Checklist

For all PR's

For new components only

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name Link
Latest commit 7225ab1d9898186586aa6ae5d3a27871f02a2116
Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/666a6a76715316000876db7d
cypress[bot] commented 1 month ago

13 failed tests on run #1901 ↗︎

13 149 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-maps): added support for vector vicmap basemaps
Project: ripple-framework Commit: 7225ab1d98
Status: Failed Duration: 06:21 💡
Started: Jun 13, 2024 3:41 AM Ended: Jun 13, 2024 3:48 AM
Failed  maps.feature • 6 failed tests View Output
Test Artifacts
Custom collection map component > Popup - 'popover' type Test Replay Screenshots
Custom collection map component > Popup - 'sidebar' type Test Replay Screenshots
Custom collection map component > Popup - 'popover' type with sidepanel Test Replay Screenshots
Custom collection map component > Popup - 'sidebar' type with sidepanel Test Replay Screenshots
Custom collection map component > Popup - Two pins in same location Test Replay Screenshots
Custom collection map component > Sidepanel - Clicking an item Test Replay Screenshots
Failed  vsba.feature • 7 failed tests View Output
Test Artifacts
School buildings map > On load Test Replay Screenshots
School buildings map > Search for postcode Test Replay Screenshots
School buildings map > Search for locality Test Replay Screenshots
School buildings map > No results message Test Replay Screenshots
School buildings map > Filters should display when expanded Test Replay Screenshots
School buildings map > Click on cluster should zoom in Test Replay Screenshots
School buildings map > Switch to list view Test Replay Screenshots

Review all test suite changes for PR #1219 ↗︎