[R20-1969] skeleton loading - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

18 stars 13 forks source link

[R20-1969] skeleton loading #1222

Closed lambry closed 3 weeks ago

lambry commented 1 month ago

Issue: https://digital-vic.atlassian.net/browse/R20-1969

What I did

Add skeleton loading states
Scroll to results on submit (can be turned off via prop)
Fix table display when sidebar is present
Fix tally/sort spacing

Listing skeleton loaders

https://github.com/dpc-sdp/ripple-framework/assets/287178/1723c092-55b6-4ea8-8df4-f04b73e43768

Map skeleton loaders

https://github.com/dpc-sdp/ripple-framework/assets/287178/d45e497d-e84a-4660-99af-6fa83a53f7a7

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[x] I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	55ad9b75730a3d8b387ec9e4e839992e2af226ef
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/6670c354c6c1ff00098ce623

cypress[bot] commented 1 month ago

Passing run #1919 ↗︎

0

170

0

0

0

Details:

refactor(@dpc-sdp/ripple-tide-search): update table skeleton, fix background col...
Project: ripple-framework	Commit: `55ad9b7573`
Status: Passed	Duration: 07:43 💡
Started: Jun 17, 2024 11:16 PM	Ended: Jun 17, 2024 11:24 PM

Review all test suite changes for PR #1222 ↗︎