dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
Apache License 2.0
20 stars 13 forks source link

[R20-2041] always ensure expanded menu is visible #1223

Closed lambry closed 3 months ago

lambry commented 3 months ago

Issue: https://digital-vic.atlassian.net/browse/R20-2041

What I did

The latest version of safari on ios was triggering a scroll when the search field was focused, this in turned triggered our menu to be hidden as that's what it does, it hides when the page is scrolled down. This issue only effected sites using the quick exit as having the quick exit in the menu pushes down the search input down just enough for safari to decided it needs to move up the page so the user can see/access the input field better.

Checklist

For all PR's

For new components only

netlify[bot] commented 3 months ago

Deploy Preview for ripple-docs canceled.

Name Link
Latest commit ac041dd1d92c3e3b1413f7679af44ab69302aa7d
Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/666fb7454d95ac00081e8cc6
cypress[bot] commented 3 months ago

Passing run #1913 ↗︎

0 162 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): allways ensure expanded menu is visible
Project: ripple-framework Commit: ac041dd1d9
Status: Passed Duration: 07:19 💡
Started: Jun 17, 2024 4:05 AM Ended: Jun 17, 2024 4:13 AM

Review all test suite changes for PR #1223 ↗︎