dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
Apache License 2.0
20 stars 13 forks source link

[R20-1969] add skeletons to site search #1233

Closed lambry closed 3 months ago

lambry commented 3 months ago

Issue: https://digital-vic.atlassian.net/browse/R20-1969

What I did

https://github.com/dpc-sdp/ripple-framework/assets/287178/5da9df39-3216-4f5c-a47f-2ad5ffb90718

Notes

One change in this PR is to swap the element type (in the search result layout components) when loading has completed, this was best way to ensure the results correctly replace skeleton screens in cypress. Without it cypress will show the result content merged into the skeleton components (as seen below).

Screenshot 2024-06-24 at 12 43 15 PM

For all PR's

For new components only

netlify[bot] commented 3 months ago

Deploy Preview for ripple-docs canceled.

Name Link
Latest commit 2339b810dbd5be57d1bc4feb4b8debe47c9f9dbb
Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/667b5733a6c53c0008d87cfc
cypress[bot] commented 3 months ago

Passing run #1975 ↗︎

0 172 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/skeleton-loading
Project: ripple-framework Commit: 2339b810db
Status: Passed Duration: 07:54 💡
Started: Jun 25, 2024 11:50 PM Ended: Jun 25, 2024 11:58 PM

Review all test suite changes for PR #1233 ↗︎