[R20-2027] set default layout background colour - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

20 stars 13 forks source link

[R20-2027] set default layout background colour #1237

Closed lambry closed 3 months ago

lambry commented 3 months ago

Issue: https://digital-vic.atlassian.net/browse/R20-2027

What I did

Some accessibility tools allow inverting a page, however without the bg being explicitly set this doesn't work well.

Before

Screenshot 2024-06-26 at 2 51 55 PM

After

Screenshot 2024-06-26 at 2 53 36 PM

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 3 months ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	f7d5cc01b88ab81ee71543037d0060e72857b55a
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/667ba6f27552b90008c81dfc

cypress[bot] commented 3 months ago

Passing run #1982 ↗︎

0

174

0

0

0

Details:

feat(@dpc-sdp/ripple-ui-core): set default layout background colour
Project: ripple-framework	Commit: `f7d5cc01b8`
Status: Passed	Duration: 07:13 💡
Started: Jun 26, 2024 5:27 AM	Ended: Jun 26, 2024 5:34 AM

Review all test suite changes for PR #1237 ↗︎