[R20-2053] Map improvements to support R20-2053 - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

18 stars 13 forks source link

[R20-2053] Map improvements to support R20-2053 #1246

Closed jeffdowdle closed 2 days ago

jeffdowdle commented 2 weeks ago

Issue: https://digital-vic.atlassian.net/browse/R20-2053

What I did

default map pin color to primary site color instead of red
fixed description list missing types
added helper components for laying out result tables
pass map deadspace to map results hook so that they can zoom correctly
fixed centreMap util when it's given a custom zoom level

How to test

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 2 weeks ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	ef6a21741eaa79fa7fbbce15942af03cfcd2d1cb
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/668ccc947d8d4700089086b5

cypress[bot] commented 2 weeks ago

Passing run #2029 ↗︎

0

174

0

0

0

Details:

fix(@dpc-sdp/ripple-ui-maps): fixed centreMap util when it's given a custom zoom...
Project: ripple-framework	Commit: `ef6a21741e`
Status: Passed	Duration: 08:09 💡
Started: Jul 9, 2024 5:39 AM	Ended: Jul 9, 2024 5:48 AM

Review all test suite changes for PR #1246 ↗︎