[SD-144] fix map fullscreen button - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

20 stars 13 forks source link

[SD-144] fix map fullscreen button #1303

Closed lambry closed 1 month ago

lambry commented 1 month ago

Issue: https://digital-vic.atlassian.net/browse/SD-144

What I did

The close button (i.e. cross icon) wasn't displaying when the map goes full screen
Also requestFullscreen is, to quote MDN "Only available on iPad, not on iPhone.", so now we don't display the full screen button if it won't work i.e. on iPhones.

How to test

Ripple 2.14.0 (current behaviour) https://www.develop.police.vic.gov.au/police-station-location?activeTab=map
Branch with this update https://app.pr-482.vicpol-vic-gov-au.sdp4.sdp.vic.gov.au/police-station-location?activeTab=map

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[x] I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus