[SD-314] Breadcrumbs enhancement - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

20 stars 13 forks source link

[SD-314] Breadcrumbs enhancement #1329

Closed waitingallday closed 1 week ago

waitingallday commented 2 weeks ago

Issue: https://digital-vic.atlassian.net/browse/SD-314

What I did

Team navigation proof of concept from sprint break

How to test

https://624ac117357335003a84dac3-acpnqqghmd.chromatic.com/?path=/story/core-navigation-breadcrumbs--example-many-links

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

cypress[bot] commented 2 weeks ago

ripple-framework Run #2256

Run Properties: Failed #2256 • 14f31aa0db: refactor(@dpc-sdp/ripple-ui-core): :recycle: use prop and featureflag

Project	`ripple-framework`
Branch Review	`feat/breadcrumbs-update`
Run status	`Failed #2256`
Run duration	`09m 36s`
Commit	`14f31aa0db: refactor(@dpc-sdp/ripple-ui-core): :recycle: use prop and featureflag`
Committer	`Jason Smith`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`195`
View all changes introduced in this branch ↗︎

Tests for review

test/features/maps/maps.feature • 1 failed test

View Output

Test		Artifacts
Custom collection map component > Popup - 'sidebar' type		`Test Replay` `Screenshots`