[INTCONTRIB-187] Added check for schema property to show/hide count in exposed filters select lists. - Githubissues

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

[INTCONTRIB-187] Added check for schema property to show/hide count in exposed filters select lists. #1150

Closed elNico closed 2 years ago

elNico commented 2 years ago

Motivation and Context

JIRA issue: https://salsadigital.atlassian.net/browse/INTCONTRIB-187

Matching BE PR:

https://github.com/dpc-sdp/content-vic-gov-au/pull/1323

Changed

Added a new schema property check to hide counts in filter select lists.
New property is elasticsearch-aggregation-show-count

In schema: https://github.com/salsadigitalauorg/content-collection-component/blob/master/src/validation/schema.json#L298 https://github.com/salsadigitalauorg/content-collection-component/blob/master/schema/schema.js#L544

Can be seen here: https://salsadigitalauorg.github.io/content-collection-component/#/

Screenshots

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

dylankelly commented 2 years ago

this has been merged as part of https://github.com/dpc-sdp/ripple/pull/1203 and released in https://github.com/dpc-sdp/ripple/pull/1211