[SDPA-6095] - Remove rainbow string from promo card - Githubissues

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

[SDPA-6095] - Remove rainbow string from promo card #1180

Closed ChrisCampbellCodes closed 2 years ago

ChrisCampbellCodes commented 2 years ago

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-6095

Changed

Removed colour stripe from the top of the card component variant called 'promo no image'

Screenshots

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

ChrisCampbellCodes commented 2 years ago

Hey @dylankelly ,

I think we need a different way of handling the variant because the 'no-image' class is still used, its styles are split up so in the PR it looks like I've removed all of its styling but it is still an existing variant. The 'promo cards' are the ones that would have the option so perhaps we could do a 'promo card - feature' variant which includes the rainbow? And regular 'promo cards' like we have now wont have the rainbow.