[SDPAP-6333] Added alt text to hero banner logos. - Githubissues

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

[SDPAP-6333] Added alt text to hero banner logos. #1228

Closed lambry closed 2 years ago

lambry commented 2 years ago

Motivation and Context

Allow alt text to be displayed for hero banner logos (primarily for screen readers).

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-6333

Changed

This update displays the logo's alt title in the hero component, this means the logo being passed to HeroBanner.vue is now an object instead of a string.

Screenshots

How Has This Been Tested?

The storybook story has been updated so the logo prop is now an object. https://storybook.pr-1228.ripple.sdp2.sdp.vic.gov.au/?path=/story/organisms-banners--hero-banner

The change can be previewed at the below URLS: Hero logo with alt text: https://app.pr-1228.ripple.sdp2.sdp.vic.gov.au/sdpta-all-components-landing-page-fixture Page with no hero logo: https://app.pr-1228.ripple.sdp2.sdp.vic.gov.au/embedded-video-test

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Note: someone more familiar with the project may be aware of any unforeseen issues around changing the prop type.

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.