dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js
Apache License 2.0
61 stars 37 forks source link

[SDPAP-6370] Removed most changes from PR 1206, updated accordion titles to h3s #1231

Closed lambry closed 2 years ago

lambry commented 2 years ago

Motivation and Context

This task was done and released in 1.40 SDPAP-6190: Ability to create/use anchor links with accordions COMPLETED, however the following considerations arose upon it’s completion and a further UI review SDP-Core-Accordion Title On This Page

The task at hand for this PR is reverting the changes from https://github.com/dpc-sdp/ripple/pull/1206

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-6370

Changed

  1. Reverted changes in packages/components/Molecules/AnchorLinks/index.vue
  2. Reverted changes in packages/components/Organisms/Accordion/Accordion.vue
    1. Update accordion title to be H3s instead of H2s
    2. Check styles split out in SCSS files
  3. Reverted changes in packages/components/Organisms/Accordion/index.js
  4. Reverted changes in packages/ripple-nuxt-tide/lib/pages/Tide.vue

Screenshots

Screen Shot 2022-08-10 at 10 59 24 am

Links

https://app.pr-1231.ripple.sdp4.sdp.vic.gov.au/ https://storybook.pr-1231.ripple.sdp4.sdp.vic.gov.au/?path=/story/organisms-accordion--accordion

Types of changes

Checklist