fix(@dpc-sdp/ripple-form): add default id prefix to forms - Githubissues

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

fix(@dpc-sdp/ripple-form): add default id prefix to forms #1236

Closed lambry closed 2 years ago

lambry commented 2 years ago

Motivation and Context

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-6368

Changed

Add default id prefix to forms; One thing to note is the duplicate ID issue would still occur if the form is on the page more than once. Probably very unlikely here, but something does occur on other sites.

How Has This Been Tested?

View prefixed form fields here: https://app.pr-1236.ripple.sdp4.sdp.vic.gov.au/sdpta-webforms-18-08-2022

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.