[SW-2204]: forward sitemap query params - Githubissues

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

[SW-2204]: forward sitemap query params #1244

Closed lambry closed 2 years ago

lambry commented 2 years ago

Motivation and Context

We need to support paged sitemaps.

JIRA issue: https://digital-vic.atlassian.net/browse/SW-2204

Changed

Forward query params in tide middleware so paginated sitemap pages can be returned.

Testing

https://app.pr-1244.ripple.sdp4.sdp.vic.gov.au/sitemap.xml https://app.pr-1244.ripple.sdp4.sdp.vic.gov.au/sitemap.xml?page=1 https://app.pr-1244.ripple.sdp4.sdp.vic.gov.au/sitemap.xml?page=2

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.