search

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js
Apache License 2.0
61 stars 37 forks source link

[SW-1635] update card collection component #1245

Closed lambry closed 2 years ago

lambry commented 2 years ago

JIRA issue: https://digital-vic.atlassian.net/browse/SW-1635

Changed

  1. Migrate patch from solar website: https://github.com/dpc-sdp/solar-vic-gov-au/blob/develop/patches/%40dpc-sdp%2Bripple-nuxt-tide%2B1.29.2.patch
  2. Update to card collection to address the following:
    • Custom no results message not displaying
    • Results not hidden when minimum number of cards isn't meet
    • Component isn't hidden when minimum number of cards isn't meet and hide component is set

For reference, the deprecated drupal fields: https://github.com/dpc-sdp/tide_automated_listing/blob/dda418f23871f2c4a1cf1ef25a71d442a1f28da3/src/Plugin/Field/FieldWidget/AutomatedListingConfigurationWidgetEnhanced.php#L541

Testing

Compare the display of the following develop page vs the same page on the PR branch.

Develop: https://www.develop.solar.vic.gov.au/test-events-collection PR: https://app.pr-89.solar-vic-gov-au.sdp4.sdp.vic.gov.au/test-events-collection

Screenshot of develop branch

develop-site

Screenshot of PR branch

pr-branch