dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js
Apache License 2.0
61 stars 37 forks source link

[SDPSUP-4751] Memory leak in v1.31 #1252

Closed FleetAdmiralButter closed 1 year ago

FleetAdmiralButter commented 1 year ago

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPSUP-4751

Changed

We've been investigating a memory leak in Ripple 1.31 where pods will gradually grow up to 4GB memory use before being killed and restarted by Kubernetes.

I've documented my findings further in the relevant support issue but it seems that this was caused by setting up the RplFormEventBus in a created lifecycle hook rather than mounted. Reverting this caused memory usage to go back down to reasonable levels under sustained load.

I'm not 100% certain of the reasoning behind this change but raising this PR for visibility.

Screenshots

How Has This Been Tested?

Types of changes

Checklist