dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js
Apache License 2.0
61 stars 37 forks source link

Release v1.35.1 #1285

Closed lambry closed 1 year ago

lambry commented 1 year ago

Motivation and Context

JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-6808

Changed

  1. New minor release to include fix for rpl-data-list result mapping (which is in develop), see: https://github.com/dpc-sdp/ripple/pull/1284

Release diff: https://github.com/dpc-sdp/ripple/compare/v1.35.0...release/1.35.1

Types of changes

Checklist

lambry commented 1 year ago

Hey @dylankelly, do I need to worry about these failing tests before finishing the release? Seems like they always fail anyway.

Screenshot 2023-03-28 at 3 39 06 pm

1.33.0 Release

Screenshot 2023-03-28 at 3 41 58 pm
dylankelly commented 1 year ago

Hey @dylankelly, do I need to worry about these failing tests before finishing the release? Seems like they always fail anyway.

Screenshot 2023-03-28 at 3 39 06 pm

1.33.0 Release

Screenshot 2023-03-28 at 3 41 58 pm

Thats a question for @klaukl or @tim-yao

tim-yao commented 1 year ago

Hey @dylankelly, do I need to worry about these failing tests before finishing the release? Seems like they always fail anyway.

Screenshot 2023-03-28 at 3 39 06 pm

1.33.0 Release

Screenshot 2023-03-28 at 3 41 58 pm

Thats a question for @klaukl or @tim-yao

Yes, we should. I see two failures, one for the promotion card and one for sitemap.xml(which is most likely a backend deployment issue that can be ignored). I will do a quick check to see why promotion card test failed.

tim-yao commented 1 year ago

You can ignore the failures @lambry . There is a known sitemap-related bug in the backend develop environment. And the promotion card issue is a false positive that can be ignored. We are working on migrating to the Nightwatch v2, which will improve the reliability and speed of the e2e regression.

lambry commented 1 year ago

Thanks @tim-yao