Closed yeniatencio closed 1 year ago
Hi @dylankelly, @yeniatencio - I just noticed this PR in passing. The change here will break places where an exposed items per page is required, like on https://www.health.vic.gov.au/search?q=eye. If the purpose is to set the items per page, but without the user configurable option, then we shouldn't be using
$config['interface']['display']['options']['itemsToLoad']['values']
from here to set the value.
Instead, try using internal.itemsToLoad
see schema:
$config['internal']['itemsToLoad']
This should be achievable in the back-end by updating the JSON configuration for the content collection, without needing this PR.
@yeniatencio In talking this through with @alan-cole , I don't think we should proceed with this PR. It looks like there has been some confusion here. The required change to add a defined number of results is needed for Ripple 2 only. By removing the ability to change the number of results we would break existing functionality in Ripple 1 (See link Alan provided).
@lambry we might need to pickup this ticket for Ripple 2.
Sorry for the confusion.
@yeniatencio In talking this through with @alan-cole , I don't think we should proceed with this PR. It looks like there has been some confusion here. The required change to add a defined number of results is needed for Ripple 2 only. By removing the ability to change the number of results we would break existing functionality in Ripple 1 (See link Alan provided).
@lambry we might need to pickup this ticket for Ripple 2.
Sorry for the confusion.
Hi @dylankelly , I was going to close this pr too and Yes agree with you. I have already deleted the variable from this pr that I was using with my BE pr. Thanks guys.
Motivation and Context
This change is required to remove the items per page dropdown box where it gives the option to select the number of pages shown. This option is being added in BE content collection by selecting numbers of results shown. 3, 6, 9.
JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-7477
BE link: https://nginx-php.pr-272.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/ FE link: https://app.pr-1305.ripple.sdp4.sdp.vic.gov.au/
Changed