[DEVOPS-248] Migrate CircleCI to Github actions

dpc-sdp / ripple

Ripple is the frontend framework for Single Digital Presence, delivered using Nuxt and Vue.js

Apache License 2.0

61 stars 37 forks source link

[DEVOPS-248] Migrate CircleCI to Github actions #1313

Closed MarkCalvert closed 9 months ago

MarkCalvert commented 10 months ago

Motivation and Context

JIRA issue: https://salsadigital.atlassian.net/browse/DEVOPS-248

Changed

Created new Github action workflows based off current CircleCI implementation

Screenshots

How Has This Been Tested?

Tested Github action workflow commit
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[ ] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

tim-yao commented 10 months ago

@MarkCalvert @FleetAdmiralButter The ci trigger is not working:

 Triggering end to end testing for ripple...
Error: No E2E GitHub token found, end to end is not triggered. Please make sure E2E_GITHUB_TOKEN is set up.

Do we need to wait for the middleware to work first then we can test it?

MarkCalvert commented 10 months ago

@tim-yao, a few things are required to test the CI nightwatch trigger. First, a GitHub access token must be added to the lagoon project for E2E_GITHUB_TOKEN. This token and API call will get replaced with the middleware work. Secondly, unfortunately and annoyingly workflow dispatches can not be tested until they are merged into the default branch which is not ideal. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch I will see if there is a workaround.

tim-yao commented 10 months ago

@MarkCalvert ok. Can you please use your own GitHub token to call the same curl request from your local? Then we can see if it works.

MarkCalvert commented 9 months ago

Hi @tim-yao, Using the GitHub CLI tool, I found a workaround to trigger the nightwatch workflow for testing. Here is the gh CLI command you can run from the locally cloned repo. gh workflow run nightwatch.yml --ref feature/migrating-circleci-to-github-actions -f e2e=true -f e2e_project=reference -f e2e_be_url=https://develop.content.reference.sdp.vic.gov.au -f e2e_fe_url=https://app.pr-1313.ripple.sdp4.sdp.vic.gov.au/

You can view the actions I have triggered for the nightwatch workflow and will notice they fail in the e2e reusable workflow tests, can you please review these?