search

dpc-sdp / tide_api

Content API for Tide distribution.
https://www.drupal.org/project/tide_api
GNU General Public License v2.0
0 stars 2 forks source link

[SDPAP-8001] Fixes an issue for preview links #116

Closed vincent-gao closed 1 year ago

vincent-gao commented 1 year ago

Jira

https://digital-vic.atlassian.net/browse/SDPAP-8001 https://digital-vic.atlassian.net/browse/SDPSUP-5026

Issue

the last release reverted the configuration back to previewer role which causes the issue, @RonaldRinaldy just fixed it by applying drush config:set tide_share_link.settings token_role administrator, this PR is a follow-up PR to make the change permanently.

vincent-gao commented 1 year ago

This is fine - but I think we need a ticket to add this check as a test so that we can protect against the regression again. What do you think?

hi @krakerag , thanks for the CR. yes, I will raise a ticket for the QA team.

vincent-gao commented 1 year ago

@anthony-malkoun thanks for reminding me this! I thought we discussed this issue. let me double-check it with Sonny.

vincent-gao commented 1 year ago

hi @anthony-malkoun ~I will be closing this ticket, as I have identified the issue.~