[SRM-702] Fix for revision loading throws error on illegal offset type.

dpc-sdp / tide_api

Content API for Tide distribution.

https://www.drupal.org/project/tide_api

GNU General Public License v2.0

0 stars 2 forks source link

[SRM-702] Fix for revision loading throws error on illegal offset type. #99

Closed MdNadimHossain closed 1 year ago

MdNadimHossain commented 1 year ago

JIRA

https://digital-vic.atlassian.net/browse/SRM-702

Issue

Some of the $vid values returned as object and which causes illegal offset type error when calling the loadRevision function. Scenario - Go to a node in any CMS and click on the revision tab. Then click on any previous revision and then the CMS will throw error.

Changes

9.4 returns the vid directly from here - $revision = $this->routeMatch->getParameter('node_revision'); https://github.com/dpc-sdp/tide_api/issues/100

MdNadimHossain commented 1 year ago

@krakerag I have updated the code from the issue raised by Govind, I couldn't cherry pick his commit as his PR is in a form branch. I wanted to add his merge request, but couldn't do that