Build on beta - Githubissues

dpc / mioco.pre-0.9

Scalable, coroutine-based, asynchronous IO handling library for Rust programming language. (aka MIO COroutines).

Mozilla Public License 2.0

457 stars 30 forks source link

Build on beta #133

Closed Ryman closed 8 years ago

Ryman commented 8 years ago

This depends on https://github.com/mvdnes/spin-rs/pull/26, but if that gets merged then this should (works for me locally) build on beta, meaning we will be able to use it on stable in a few weeks 👍

This lifts https://github.com/sfackler/r2d2/blob/master/src/thunk.rs wholesale from r2d2, which is MIT/APACHE licensed (I think it's originally taken from rust itself). I'm not 100% sure on the compatibility of MPL but since you're already depending on rust itself then it's probably fine?

dpc commented 8 years ago

Nice! Thanks!

Could you add https://docs.travis-ci.com/user/languages/rust "allow_failures" for beta, so until spin is not ready, the travis build stays green? (I don't want to scare users off by having a red builds)