search

dpc / mioco.pre-0.9

Scalable, coroutine-based, asynchronous IO handling library for Rust programming language. (aka MIO COroutines).
Mozilla Public License 2.0
457 stars 30 forks source link

Initial timer implementation #20

Closed jeremyjh closed 9 years ago

dpc commented 9 years ago

I think it would be better if you just squashed my patches into your change so it's a one self-contained feature-adding fix. I'm still unsure about API details, but it looks good enough to merge and we can bikesched afterwards.

Let me know about the squashing, fixing spacing and minor fixes. I can just fix them along the way later.

Seems to me Timers are making mioco feature complete for 0.1 and I'm very happy about it! Thanks!

jeremyjh commented 9 years ago

Ok - I will fix this up - thanks for all the comments. Just to 2x check - I did squash your two final commits but you want me to squash the wakups branch changes too?

dpc commented 9 years ago

Ah. No. Sorry, my mistake.

jeremyjh commented 9 years ago

Ok fixed up per your comments and re-squashed.