dpc10ster commented 5 years ago

https://api.travis-ci.org/v3/job/549430122/log.txt

Passes R CMD check on my machine

pwep commented 5 years ago

Looking at the Travis log for build 193, the failing test is as follows:

── 1. Failure: known hash (@test-compare-3fits.R#24)  ──────────────────────────
Value hashes to ee6f623095, not 6a90170dda

The expect_known_hash test at the end of test-compare-3fits.R is till there in the master branch. https://github.com/dpc10ster/RJafroc/blob/fa6db3965c53c49976b7435174c424e7b1f6d524/tests/testthat/test-compare-3fits.R#L19-L24

I will let you delete these lines from test-compare-3fits.R in the development branch, and merge the development branch into master. (No point generating a pull request for this fix)

pwep commented 5 years ago

I note your comment on commit 47ee231

# unfortunately this causes Failures on Travis; differences are in the 6th decimal place

...and that difference will be why the hash value on Travis does not match the hash value hard-coded as an argument to expect_known_hash in test-compare-3fits.R (and results in a failed test)

dpc10ster commented 5 years ago

You explained it all so well; thank you and I will not ruin your weekend any further; Dev

On Sun, Jun 23, 2019 at 3:13 PM Peter Phillips notifications@github.com wrote:

I note your comment on commit 47ee231 https://github.com/dpc10ster/RJafroc/commit/47ee2319c08eaec2d85db1da3fd5a37e7e40dba5

unfortunately this causes Failures on Travis; differences are in the 6th decimal place

...and that difference will be why the hash value on Travis does not match the hash value hard-coded as an argument to expect_known_hash in test-compare-3fits.R

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dpc10ster/RJafroc/pull/16?email_source=notifications&email_token=AH4NJRGWF5CWKA22NJKOYM3P37DLZA5CNFSM4H2ZQTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYLE7TQ#issuecomment-504778702, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4NJRBIW35UKVJ24PSOWFTP37DLZANCNFSM4H2ZQTFA .

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fa6db39). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   79.29%           
=========================================
  Files             ?       56           
  Lines             ?     7307           
  Branches          ?        0           
=========================================
  Hits              ?     5794           
  Misses            ?     1513           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa6db39...8457b7d. Read the comment docs.

dpc10ster commented 5 years ago

Pull request successfully merged and closed You’re all set—the development branch can be safely deleted.

I did not delete it

pwep commented 5 years ago

I did not delete it

Quite right. Changes get their own named branch, which get pulled into the development branch via pull request. When you are happy that development branch is ready for release to the wider public, you merge changes into the master branch.

dpc10ster / RJafroc

Why is Travis failing? #16

unfortunately this causes Failures on Travis; differences are in the 6th decimal place

Codecov Report