dpeerlab / Harmony

Harmony framework for connecting scRNA-seq data from discrete time points
GNU General Public License v2.0
44 stars 12 forks source link

scikit-learn dependency #16

Open adamgayoso opened 3 years ago

adamgayoso commented 3 years ago

Hi all,

I just wanted to point out that this dependency should probably be scikit-learn.

https://github.com/dpeerlab/Harmony/blob/eca0771348e7f1b901f95d1a8fc68d95530e830c/setup.py#L34

ManuSetty commented 3 years ago

Thanks a lot for pointing this out Adam - we will have this fixed. Sorry for such a delayed response!

sarajimenez commented 7 months ago

Hi! Any chance you solved this dependency issue? otherwise, do you have any advise on how to get around it? Thank you so much :)

EamonCoughlan commented 5 months ago

Had this issue with trying to install direct via pip, followed by an error with fa2 when trying to install direct from the git repo via pip git+. The solution for anyone running into the same error was to first install fa2 via conda ('conda install -c conda-forge fa2') and then to install harmonyTS through pip git+.

hamidghaedi commented 5 months ago

@EamonCoughlan thank you so much for your comment! It worked for me .