search

dpeerlab / spectra

Supervised Pathway DEConvolution of InTerpretable Gene ProgRAms
MIT License
134 stars 17 forks source link

Fix packaging data #13

Closed mxposed closed 1 year ago

mxposed commented 1 year ago

Judging from the notebook, I thought that you'd like to put the data files in the package itself, so if this is indeed the case, here's a pull request to do it properly.

First, I switched to find_packages to discover packages, in case you will have some subpackages in spectra directory. For this to work, I also added the __init__.py file (which is actually required for python packages). And then I moved data inside the package and added corresponding installation into setup.py

Also, I am installing directly from github with pip install git+https://github.com/dpeerlab/spectra#egg=spectra, or some people even do it by linking to github release archive, so you don't need git to install.

Hope this helps

wallet-maker commented 1 year ago

Hi, sorry I didn't reply earlier Thank you for the helpful suggestion. For now we don't want to put the data files into the package but we'll continue thinking about that and might come back to this later.

mxposed commented 1 year ago

Hi, no worries. Sorry I misinterpreted your intention, please feel free to close this pull request