dpeerlab / spectra

Supervised Pathway DEConvolution of InTerpretable Gene ProgRAms
MIT License
150 stars 17 forks source link

Add message about Convergence #27

Open nickp60 opened 1 year ago

nickp60 commented 1 year ago

Hi SPECTRA team! This PR is a small suggestion to add a status message after training to indicate that its ok if the model converges early. Since the the progress bar is there, it can look like an error occurred if it stops processing at say 12% without any message. It looks like this confusion has been reported before. An alternative would be updating the docs and maybe renaming num_epochs to max_epochs to imply that its expected that a solution will be reached sooner.

Happy to change the message to whatever you think is the most appropriate!