dpenkler / linux-usbtmc

Experimental linux usbtmc driver
GNU General Public License v2.0
21 stars 12 forks source link

Setting timeout from user-space program #1

Closed amba closed 6 years ago

amba commented 7 years ago

The fixed timeout of 5 seconds has been a serious problem of the linux usbtmc driver. With our equipment, there are many cases where 5 seconds is either to long or too short. Making it configurable via module_param() is a good thing, but requires reloading of the module and root permissions.

It would be better, if the timeout could be set by the user program. If I can do this with the Linux-GPIB library, why not with the linux USBTMC driver? ;)

dpenkler commented 7 years ago

Hi Simon, Your are right. I will add an ioctl to set the timeout programmatically. Thanks, -Dave

On Sun, Oct 29, 2017 at 2:43 PM, Simon Reinhardt notifications@github.com wrote:

The fixed timeout of 5 seconds has been a serious problem of the linux usbtmc driver. With our equipment, there are many cases where 5 seconds is either to long or too short. Making it configurable via module_param() is a good thing, but requires reloading of the module and root permissions.

It would be better, if the timeout could be set by the user program. If I can do this with the Linux-GPIB library, why not with the linux USBTMC driver? ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dpenkler/linux-usbtmc/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQM7Uv6yMEgqfG6PqvCm16nfJ035VF4ks5sxIEBgaJpZM4QKUXR .

dpenkler commented 7 years ago

Hi Simon, I pushed a change for this. Please could you test it ? thanks, -Dave

On Sun, Oct 29, 2017 at 6:47 PM, dave penkler dpenkler@gmail.com wrote:

Hi Simon, Your are right. I will add an ioctl to set the timeout programmatically. Thanks, -Dave

On Sun, Oct 29, 2017 at 2:43 PM, Simon Reinhardt <notifications@github.com

wrote:

The fixed timeout of 5 seconds has been a serious problem of the linux usbtmc driver. With our equipment, there are many cases where 5 seconds is either to long or too short. Making it configurable via module_param() is a good thing, but requires reloading of the module and root permissions.

It would be better, if the timeout could be set by the user program. If I can do this with the Linux-GPIB library, why not with the linux USBTMC driver? ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dpenkler/linux-usbtmc/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQM7Uv6yMEgqfG6PqvCm16nfJ035VF4ks5sxIEBgaJpZM4QKUXR .

GuidoKiener commented 6 years ago

Hi Dave,

It's a good idea to change the timeout with the new USBTMC488_IOCTL_TIMEOUT command. However I think we will need more flexibility and a device specific timeout value instead of just one global usb_timeout value. My first approach would be:

Regards Guido