search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
103 stars 35 forks source link

fix: prevent `SyntaxError` while parsing `:has` pseudo selectors #112

Closed seckardt closed 3 months ago

seckardt commented 4 months ago

Fix for issue #111

dperini commented 4 months ago

@seckardt Yes ... there are other similar issues that were introduced between 2.2.x and 2.2.7 because of poor testing on my side. I am finally home ready to land several patches and improvements so I need help from everybody using "nwsapi".

I have to complete setting up a continuous testing tool, based on WPT which has been delayed for several months now. This will be something useful for everybody and would be used to confirm bugs after comparing functionality and outcome with standards browser behaviours.

Thank you so much for your great contribution. Looking forward for other fixes, stay tuned. Your help much appreciated.

seckardt commented 3 months ago

@dperini Any ETA when either this PR or another/wider fix might hit master and leads to a new release?

dperini commented 3 months ago

@seckardt it will be very soon. I hope to have master updated & ready to test then push to npm 2.2.10. I am executing all my tests and wpt tests once more to ensure not forgetting obvious checks.

dperini commented 3 months ago

@seckardt I merged your fix ... can you check it out for last minute bugs that you might have encountered ? Thank you.