New web platform test failures in 2.2.10 - Githubissues

dperini / nwsapi

Fast CSS Selectors API Engine

MIT License

101 stars 34 forks source link

New web platform test failures in 2.2.10 #115

Open domenic opened 1 month ago

domenic commented 1 month ago

The following are the tests that fail in 2.2.10 which have been passing in 2.2.7:

From https://github.com/web-platform-tests/wpt/tree/master/css/selectors
- dir-pseudo-on-bdi-element.html
- focus-display-none-001.html
- focus-visible-014.html
From https://github.com/web-platform-tests/wpt/tree/master/html/semantics/selectors
- pseudo-classes/dir01.html
From https://github.com/web-platform-tests/wpt/tree/master/dom/nodes/
- Element-matches.html and Element-webkitMatchesSelector.html (basically duplicate tests)

dperini commented 1 month ago

Thank you @domenic ... I am working on the bugs/fixes you listed. Especially trying to resolve the is not a valid selector regression.

alopix commented 1 month ago

If it helps your debugging/fixing @dperini, a selector that has started failing with the latest 2.2.10 release is #main-content [class*="-Wrapper "]~[class*="-Paragraph "] which the is not a valid selector error. Not quit sure which part it does not like.

dperini commented 1 month ago

@alopix thank you for the help. Yes it is the same bug affecting everybody. Still need a couple of days working on it and testing.

dperini commented 1 month ago

@domenic the parsing bug was fixed and I believe I took care of all the other issues you mentioned above. You can tell if this is good enough for a new release on npm or if you need other changes/additions. Next release will be 2.2.12 and I will skip 2.2.11 as a marker of the problem I incurred with failing RE.

dperini commented 1 month ago

@alopix could you also check your problem has been fixed by these latest changes ? Thank you in advance for the great help and reviews.

alopix commented 1 month ago

@dperini thanks for working on this. I just checked and the selector seems to be working again with jsdom using your main branch 👍

dperini commented 1 month ago

@alopix thank you so much for the tests. Your help appreciated.

moekify commented 1 week ago

@dperini Any update on when you will release 2.2.12? :)

dperini commented 1 week ago

@moekify we are near to it ... very near. Anything you would like to see added or fixed ? Does nwsapi work for you in its current state.

moekify commented 1 week ago

No we definitely need the fix :) but not crazy urgent, just wanted to be able to communicate something upstream.

Thanks for your work on this :)

dperini commented 1 week ago

@domenic nwsapi Release 2.2.12 has just been pushed to npm.