search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
107 stars 37 forks source link

jsdom should be in devDependencies #25

Closed renchap closed 5 years ago

renchap commented 5 years ago

In the latest release you added jsdom as a dependency, but as it is only used for tests it should a dev dependency to avoid any package user installing it.

nickschot commented 5 years ago

This dependency also broke node 6 support as that version of jsdom does not support it.

dperini commented 5 years ago

@renchap @nickschot thank you for reporting the issue. I simply removed the dependencies from the package.json file then published a new version 2.1.3. No functional changes committed.

renchap commented 5 years ago

Thanks!