search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
105 stars 36 forks source link

test(selectors): Add tests for the `:matches(…)` selector #29

Closed ExE-Boss closed 4 years ago

ExE-Boss commented 4 years ago

This adds tests for the :matches(…) selector.

Part of #28

I’d much prefer if this used a proper test suite, like jest, and run it in a CI provider, eg. GitHub Actions or Travis CI.

dperini commented 4 years ago

@ExE-Boss as explained in issue #29 there is a complete WPT set of tests for the matches() selector already included in nwsapi. These tests are not well documented but following instructions in issue #29 it should be easy to perform (there are over 650 test just for the matches() selector).

dperini commented 4 years ago

@ExE-Boss I merged these test anyway even if they are available as part of the wpt test suite. There is no damage in having some duplicated tests.