search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
105 stars 36 forks source link

Fix queries by tag name for elements in a non-default namespace. #36

Closed willstott101 closed 4 years ago

willstott101 commented 4 years ago

Should fix: https://github.com/dperini/nwsapi/issues/5 https://github.com/jsdom/jsdom/issues/1587 https://github.com/jsdom/jsdom/issues/2159

I don't think I've run all the relevant tests as I couldn't really figure out how. But this patch makes no difference to the w3c-selector-test results afaict.

willstott101 commented 4 years ago

And the slick tests still pass

dperini commented 4 years ago

@willstott101 thank you so much for the contribution and help with this namespace improvement. This weekend I will have some time to review the patches and possibly add these new features. I really appreciate your time & efforts.

dperini commented 4 years ago

@willstott101 I tested the the patch, it works and doesn't produce any regression that I could test. I tested also with jsdom wpt tests, everything seems correct, no failure either. So I merged your pull request. Thank you again !