search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
105 stars 36 forks source link

Special-case telephone inputs in :dir() #45

Open domenic opened 3 years ago

domenic commented 3 years ago

This has always been part of the spec in https://html.spec.whatwg.org/#the-directionality , but it was not tested until recently. Tests were added in https://github.com/web-platform-tests/wpt/commit/aaf496b42ecc050fbfcc05487958f245d5a9d869#diff-fdae72426568d9ed77d62e6784fb362e247cffac722f639fd436e024b595adda and nwsapi + jsdom do not pass them.

Not a very high priority, but I thought you'd like to know!

domenic commented 3 years ago

Probably a separate bug, but perhaps one that would be fixed by implementing that spec section... nwsapi + jsdom do not pass https://github.com/web-platform-tests/wpt/blob/aaf496b42ecc050fbfcc05487958f245d5a9d869/html/semantics/selectors/pseudo-classes/dir-html-input-dynamic-text.html either.

dperini commented 3 years ago

@domenic I will have a look at both issues soon and let you know. It was a difficult period for me these last six months, I hope I can recover the delay. There were already changes in nwsapi that were not ported into a new npmjs release. A new release is due so stay tuned.

domenic commented 3 years ago

No worries, and take care! I'm sorry to hear it's been a difficult time recently; please take care of yourself. Your work is very much appreciated!

dperini commented 1 year ago

@domenic both the above issues should have been cleared by current release. Feel free to reopen in case they are still producing errors or anomalies.