search

dperini / nwsapi

Fast CSS Selectors API Engine
MIT License
103 stars 35 forks source link

:active always returning true since 2.2.7 #99

Closed SantoJambit closed 4 months ago

SantoJambit commented 10 months ago

In https://github.com/jsdom/jsdom/issues/3610 I noticed, that the :active selector always returns true. This happened with nwsapi 2.2.7. You already have the fix/revert in the master branch, but not released yet. Any chance of this getting released soon?

Thanks

dperini commented 10 months ago

@SantoJambit will do my best to release 2.2.8 next week since at the moment I am travelling and I don't have my desktop PC with me.

antoniogamizbadger commented 10 months ago

Looking forward to this! :D Thanks!!

mxgit1090 commented 9 months ago

Looking forward to this for 1 month and more!! Thanks!!

alopix commented 4 months ago

Any change this is gonna be released soon? Have bee stuck updating jsdom since December due to this bug 😅

dperini commented 4 months ago

Forgive my absence but this was not under my control, health and other problems took the precedence over everything else in the last year. However I am ready to start again and try recover your trust by fixing most existing problems. I surely need everybody help testing and for this reason I opted to use WPT to have a reliable tool and environment to test. Stay tuned !

alopix commented 4 months ago

Sorry to hear you were unwell @dperini and glad to hear you are better! Health ansd wellbeing definitely come first!

SantoJambit commented 4 months ago

I've just installed 2.2.9 and it seems to work. Thanks :)

WesCossick commented 3 months ago

@dperini This issue has regressed in v2.2.10. It was fixed in v2.2.8 and v2.2.9, but has reappeared in v2.2.10.