dperson / samba

Samba docker container
GNU Affero General Public License v3.0
1.53k stars 516 forks source link

add wsdd support? #271

Closed Dodgexander closed 4 years ago

Dodgexander commented 4 years ago

As discussed before in #10 and also mentioned a few times in other issues, Microsoft decided to drop auto discovery of SMB servers in their recent Windows 10 updates.

To cut a long story short this happened because disabled SMB v1 by default as they felt it to be a security risk.

The result for windows users is that network shares are no longer auto discoverable like they used to be.

Not just this, but because SMB v1 support was dropped by default from windows, trying to use NMBD to get windows to automatically display the shares no longer works either.

The only workaround in Linux seems to be to implement something called "WSDD" mentioned here: https://www.ixsystems.com/community/resources/how-to-kill-off-smb1-netbios-wins-and-still-have-windows-network-neighbourhood-better-than-ever.106/

Freenas have integrated into their OS as shown here: https://github.com/freenas/ports/pull/226 and its currently available in their test builds.

My question is, is it possible to get WSDD support added somehow to this container?

Yes you don't need it, but it certainly takes away the hassle with people using lots of windows computers on the network (like me) to be able to auto discover network shares without having to map drives manually.

regardless of whether this is possible I want to say thanks for making this excellent container, its been crucial for me. Great work!

dperson commented 4 years ago

From what I've just read of wsdd, it doesn't seem to work if it's not on the hosts network either (similar to NMBd). I'd like to have this working though if you find a way of making it work. Thanks.

Dodgexander commented 4 years ago

From what I've just read of wsdd, it doesn't seem to work if it's not on the hosts network either (similar to NMBd). I'd like to have this working though if you find a way of making it work. Thanks.

I'm no guru, but in the documentation here: https://github.com/christgau/wsdd it states the issue with wsdd working in docker containers is that it by default binds to all network interfaces.

The installation of wssd is in a python script that requires python 3 libraries to be installed, so for it to work with this container the container itself would need to have these libraries for it to be 'installable'.

The steps on installing it are pretty easy, I'm just unaware how flexible this container can be in terms of downloading and installing additional libraries and I'm not certain which interface within the container to use to bind wsdd too.

https://github.com/christgau/wsdd

dperson commented 4 years ago

It uses multicast, and that's not going to make it from the docker network to your normal LAN.