dperson / samba

Samba docker container
GNU Affero General Public License v3.0
1.52k stars 513 forks source link

Healthcheck fails if encrypted connection is desired #323

Open lenucksi opened 4 years ago

lenucksi commented 4 years ago

Thanks for creating this nice container. I've added a GLOBAL: "smb encrypt = desired" line to my compose-file to enable encrypted connections. This works well and the server starts serving encrypted connections. However, the healthcheck of the container does not return healthy any more once this is set. An attempt to run the healthcheck on the within the container console yields a segfault of the smbclient.

Running the command smbclient healthcheck command with an added -e parameter works as long as there is a valid user provided. I could not figure out quickly if and what the % sign in the healthcheck command smbclient -L \\localhost -U % -m SMB3 is replaced with.

Do you have any idea how this can be fixed? It might also be worth to add the above GLOBAL stanza to the defaults, as it still is possible to connect without encryption.

cobolbaby commented 4 years ago

You can try to declare the healthcheck configuration in docker-compose.yml to override the default.

edocollado commented 3 years ago

Thanks for creating this nice container. I've added a GLOBAL: "smb encrypt = desired" line to my compose-file to enable encrypted connections. This works well and the server starts serving encrypted connections. However, the healthcheck of the container does not return healthy any more once this is set. An attempt to run the healthcheck on the within the container console yields a segfault of the smbclient.

Running the command smbclient healthcheck command with an added -e parameter works as long as there is a valid user provided. I could not figure out quickly if and what the % sign in the healthcheck command smbclient -L \\localhost -U % -m SMB3 is replaced with.

Do you have any idea how this can be fixed? It might also be worth to add the above GLOBAL stanza to the defaults, as it still is possible to connect without encryption.

can you share your docker-compose file?