search

dperson / samba

Samba docker container
GNU Affero General Public License v3.0
1.5k stars 509 forks source link

Update base image to alpine:latest #423

Open nickm18471 opened 1 year ago

nickm18471 commented 1 year ago

This sets the base image to be alpine:latest ensuring the latest version of Alpine is always used.

This is important because older versions of Alpine no longer receive security updates. The version that was last built and pushed to docker hub contains a number of critical security vulnerabilities.

Additionally, I have removed the -S flag and replaced it with --debug-stdout from the smbd command in samba.sh because it is not supported in version 4.15.7 which is current for Alpine Linux 3.16.2. This was the minimum change required to get the container to run with the latest version of Alpine Linux.

prashker commented 1 year ago

Sad that this won't be merged, works great.

uPagge commented 1 year ago

I added this to my fork. By the way, you don't have to add latest, if you don't specify a tag, it defaults to latest

DockerHub: https://hub.docker.com/r/upagge/samba GitHub: https://github.com/uPagge/samba

ovizii commented 1 year ago

I added this to my fork. By the way, you don't have to add latest, if you don't specify a tag, it defaults to latest

DockerHub: https://hub.docker.com/r/upagge/samba GitHub: https://github.com/uPagge/samba

Is your fork a drop-in replacement for the original dperson/samba image?