search

dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.69k stars 1.36k forks source link

Update OAUTH docs to include other providers #1611

Open thesuperzapper opened 3 years ago

thesuperzapper commented 3 years ago

Currently we only include twitter, google, openshift and okta in the Security Docs, this causes people to have issues (especially with AzureAD, as it's not listed, but is very common).

In our example config.py, there are more OAUTH providers (Including AzureAD), we should copy these into the Security doc, and possibly improve the Security docs to include what must be setup on the OAUTH provider end.

thesuperzapper commented 3 years ago

@dpgaspar thoughts on this?

dpgaspar commented 3 years ago

Yes that's a good idea

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

sfirke commented 1 year ago

I'm looking at updating the Apache Superset OAuth docs and my preference would be to update the FAB docs instead and then redirect from Superset, so things are only maintained in one place.

The FAB situation has reversed from when this issue was opened, there are more examples in the docs than in the config.py example. The four in the config.py are all present in the docs. But having things in two places, they can grow mismatched -- I see a line in FAB docs Okta config that is missing from the config.py Okta config: "server_metadata_url": f"https://OKTA_DOMAIN.okta.com/.well-known/openid-configuration",

I would propose: a) this issue can be closed b) it would be easier to maintain if there was less duplication in the docs, so reduce the config.py example to a single OAuth provider example and add a link back to the Security docs. Where configs differ in config.py vs. security docs, take this time to pick the correct one.

sfirke commented 1 year ago

I would be willing to create a PR for this, the only part I can't do is resolve any conflicts in OAuth configs between config.py and docs for the four providers listed in both. If someone will help with that and this approach is desirable, let me know.