search

dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.64k stars 1.35k forks source link

Old mongoengine library in CI test pipelines for mongodb #1793

Open yuyou opened 2 years ago

yuyou commented 2 years ago

If you'd like to report a bug in Flask-Appbuilder, fill out the template below. Provide any extra information that may be useful

Responsible disclosure: We want to keep Flask-AppBuilder safe for everyone. If you've discovered a security vulnerability please report to danielvazgaspar@gmail.com.

Environment

Flask-Appbuilder version: the latest one

pip freeze output: N/A

Describe the expected results

In the CI piepeline, the test pipelines for MongoEngine tried to install the library "mongoengine", which shows "mongoengine-0.7.1 mongoengine-0.7.10"

The latest stable version may be 0.23.1 for a year. Without the latest stable one, some features like EnumField in MongoDB would not be possibly supported.

See the output of the CI pipeline at the phase "Install dependencies" Successfully installed apispec-3.3.2 attrs-21.2.0 babel-2.9.1 click-7.1.2 colorama-0.4.4 defusedxml-0.7.1 dnspython-2.1.0 email-validator-1.1.3 flask-1.1.4 flask-babel-2.0.0 flask-jwt-extended-3.25.1 flask-login-0.4.1 flask-openid-1.3.0 flask-sqlalchemy-2.5.1 flask-wtf-0.14.3 greenlet-1.1.2 idna-3.2 importlib-metadata-4.8.1 itsdangerous-1.1.0 jinja2-2.11.3 jsonschema-3.2.0 markupsafe-2.0.1 marshmallow-3.13.0 marshmallow-enum-1.5.1 marshmallow-sqlalchemy-0.26.1 prison-0.2.1 pyjwt-1.7.1 pyrsistent-0.18.0 python-dateutil-2.8.2 python3-openid-3.2.0 pytz-2021.1 pyyaml-5.4.1 six-1.16.0 sqlalchemy-1.4.29 sqlalchemy-utils-0.37.8 typing-extensions-3.10.0.2 werkzeug-1.0.1 wtforms-2.3.3 zipp-3.5.0

Describe the actual results2

Please upgrade the "mongoengine" version to the stable one "0.23.1" for other MongoDB-related PRs to be requested.

All MongoDb related dependencies are defined in the file "requirements-extra.txt"

mongoengine>=0.7.10, <0.7.99
flask-mongoengine==0.7.1
pymongo>=2.8.1, <2.8.99

Steps to reproduce

Every push would trigger the CI pipeline(s) including the MongoDB tests.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you