search

dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.58k stars 1.34k forks source link

Pinning to click 7.1.2 is causing conflicts #1800

Open waTeim opened 2 years ago

waTeim commented 2 years ago

If you'd like to report a bug in Flask-Appbuilder, fill out the template below. Provide any extra information that may be useful

Responsible disclosure: We want to keep Flask-AppBuilder safe for everyone. If you've discovered a security vulnerability please report to danielvazgaspar@gmail.com.

Environment

Flask-Appbuilder version:

all versions

Steps to reproduce

combine in a program needing black >= 22.x

The issue is that the latest released, stable black depends on click >= 8, while flask-appbuilder requires 7.1, an unresolvable conflict.

Click 8 has been released for 9 months (May 2021) so it's reasonable that flask-appbuilder should use/support it.

dpgaspar commented 2 years ago

Click is only pinned on the requirements.txt no package dependency. Yet Flask 1.1.X sets click >= 5.1, < 8.0. So before being able to bump click we need to bump Flask. This is on the roadmap