search

dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.63k stars 1.35k forks source link

feat: LDAP - add flag which enable nested groups for MS AD #2173

Open barloc opened 9 months ago

barloc commented 9 months ago

Description

Enable search for user nested groups in LDAP system. Use attribute member:1.2.840.113556.1.4.1941: for Microsoft Active Directory and set groups from the search to the user_info[self.auth_ldap_group_field] field.

Add flag AUTH_LDAP_USE_NESTED_GROUPS_FOR_ROLES which enables this feature. Default value is False.

Fix this issues:

ADDITIONAL INFORMATION

codecov[bot] commented 9 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (59db85d) 79.31% compared to head (b9df441) 74.32%.

Files Patch % Lines
flask_appbuilder/security/manager.py 42.85% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2173 +/- ## ========================================== - Coverage 79.31% 74.32% -5.00% ========================================== Files 72 72 Lines 8974 8930 -44 ========================================== - Hits 7118 6637 -481 - Misses 1856 2293 +437 ``` | [Flag](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2173/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2173/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | `74.32% <42.85%> (-5.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lfrancke commented 6 months ago

@barloc Can I ask what the status of this is? I do see build failures and I assume it's now at least partially outdated.

Do you plan to work on this?