feat: LDAP - add flag which enable nested groups for MS AD

barloc commented 1 year ago

Description

Enable search for user nested groups in LDAP system. Use attribute member:1.2.840.113556.1.4.1941: for Microsoft Active Directory and set groups from the search to the user_info[self.auth_ldap_group_field] field.

Add flag AUTH_LDAP_USE_NESTED_GROUPS_FOR_ROLES which enables this feature. Default value is False.

Fix this issues:

ADDITIONAL INFORMATION

[x] Has associated issue:
[ ] Is CRUD MVC related.
[x] Is Auth, RBAC security related.
[ ] Changes the security db schema.
[x] Introduces new feature
[ ] Removes existing feature

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.32%. Comparing base (59db85d) to head (b9df441). Report is 35 commits behind head on master.

Files with missing lines	Patch %	Lines
flask_appbuilder/security/manager.py	42.85%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2173 +/- ## ========================================== - Coverage 79.31% 74.32% -5.00% ========================================== Files 72 72 Lines 8974 8930 -44 ========================================== - Hits 7118 6637 -481 - Misses 1856 2293 +437 ``` | [Flag](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2173/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2173/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | `74.32% <42.85%> (-5.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lfrancke commented 9 months ago

@barloc Can I ask what the status of this is? I do see build failures and I assume it's now at least partially outdated.

Do you plan to work on this?

chevcheli0s commented 2 months ago

@barloc do you plan to implement this?

barloc commented 2 months ago

@barloc Can I ask what the status of this is? I do see build failures and I assume it's now at least partially outdated.

Do you plan to work on this?

hello sorry for long answer yep, i'll update code

barloc commented 2 months ago

Hello I added test for the feature but test-mssql is broken and I don't understand how to fix it :(

dpgaspar / Flask-AppBuilder