dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.63k stars 1.35k forks source link

fix: Increase upper bound on marshmallow-sqlalchemy #2191

Closed spike77453 closed 6 months ago

spike77453 commented 7 months ago

Description

This increases the maximum allowed version of marshmallow-sqlalchemy to 0.28.x: marshmallow-sqlalchemy < 0.28.1 no longer works on Python 3.12 since it still uses distutils which was removed from Python (see PEP 632). This in turn means that Flask-AppBuilder currently doesn't work on Python 3.12 out of the box.

In marshmallow-sqlalchemy >= 0.28.1 distutils.version.LooseVersion was replaced with packaging.version.Version: https://github.com/marshmallow-code/marshmallow-sqlalchemy/commit/1826a475335879763d449d159c0cd6a40644f874

Similar changes have been previously submitted: https://github.com/dpgaspar/Flask-AppBuilder/pull/1905

ADDITIONAL INFORMATION

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f00efc) 79.71% compared to head (ab88983) 79.71%. Report is 3 commits behind head on master.

:exclamation: Current head ab88983 differs from pull request most recent head 93e64cf. Consider uploading reports for the commit 93e64cf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2191 +/- ## ======================================= Coverage 79.71% 79.71% ======================================= Files 72 72 Lines 8990 8990 ======================================= Hits 7166 7166 Misses 1824 1824 ``` | [Flag](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2191/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/dpgaspar/Flask-AppBuilder/pull/2191/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar) | `79.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Vaz+Gaspar#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpgaspar commented 6 months ago

Thank you @spike77453