Closed spike77453 closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6f00efc
) 79.71% compared to head (ab88983
) 79.71%. Report is 3 commits behind head on master.:exclamation: Current head ab88983 differs from pull request most recent head 93e64cf. Consider uploading reports for the commit 93e64cf to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you @spike77453
Description
This increases the maximum allowed version of marshmallow-sqlalchemy to 0.28.x: marshmallow-sqlalchemy < 0.28.1 no longer works on Python 3.12 since it still uses distutils which was removed from Python (see PEP 632). This in turn means that Flask-AppBuilder currently doesn't work on Python 3.12 out of the box.
In marshmallow-sqlalchemy >= 0.28.1
distutils.version.LooseVersion
was replaced withpackaging.version.Version
: https://github.com/marshmallow-code/marshmallow-sqlalchemy/commit/1826a475335879763d449d159c0cd6a40644f874Similar changes have been previously submitted: https://github.com/dpgaspar/Flask-AppBuilder/pull/1905
ADDITIONAL INFORMATION