dpguthrie / dbtc

39 stars 12 forks source link

adds version option #68

Closed LucaSforza closed 1 year ago

LucaSforza commented 1 year ago

As requested in #66 I created the option to print the version on dbtc

dpguthrie commented 1 year ago

Thanks for opening this up @LucaSforza, I appreciate the contribution! Couple of comments:

LucaSforza commented 1 year ago

I added the function version(__package__) imported from module importlib_metadata,so I no longer use any global variables.

Now I should have solved the problem, tell me if everything is OK

dpguthrie commented 1 year ago

Thanks for making some of those changes. Couple things that I'd like to see though:

Also, it looks like your last commit included some irrelevant files .DSStore.

LucaSforza commented 1 year ago

Ok i created the file _version.py with inside has the variable __version__ ,please update me if everything is fine this time

dpguthrie commented 1 year ago

Could you remove the .DSStore file in this PR?

LucaSforza commented 1 year ago

Ok, sorry I didn't see that there were others left, now they should all have been deleted