search

dphdmn / betterLeaderboard

Unofficial leaderboard for sliding puzzle simulator slidysim.com
0 stars 0 forks source link

Popular Categories players / categories counters are inaccurate (fixed, but there are major performance issues) #11

Open dphdmn opened 1 week ago

dphdmn commented 1 week ago

this is because of hardcoded filters for bs categories with 0s WR, but maybe there is something else

Example: Maximal unsolved at Max categories amount: 1 (4x4) [Min. amount of players: 12] Real value: 10

Also in some display types some of such categories are shadows, for example, when you change from 10 to 11, an invisible category is added, so after that the categories counter itself is wrong, overcounting what is really shown

dphdmn commented 1 week ago

Ok this is really weird For standard at 4x4 (1 category) it counted 690 while there are only 476

dphdmn commented 1 week ago

Checked the logs, it is because players counter includes different control types as different scores

dphdmn commented 1 week ago

fixed in https://github.com/dphdmn/betterLeaderboard/commit/ffaed8d62c77a15ce889b049601ce659d87e8ed1 but now there are performance issues, because it has to check all categories all the time each time you move the slider, it has to be optimized by saving temporary data