search

dphuang2 / PoGoBag

Analyze and share your Pokémon through a locally run server! Official Site access has been stopped as of 12/23/2016
146 stars 49 forks source link

Added nickname mapping and display on pokemon card #85

Open shinyuX opened 8 years ago

shinyuX commented 8 years ago

A useless yet essential feature : pokemon nicknames !

screenshot
Maxoul commented 8 years ago

Seems neat !

Limeliz commented 8 years ago

Good add, which I've been thinking about adding myself. But you need to make the pokemon card higher, because the stamina-bar is clipping throught the bottom of the card for those pokemons who have a nickname. image

shinyuX commented 8 years ago

I had made the card bigger (see my screenshot), I might need to rebase the last added modifications

YesThatAllen commented 8 years ago

I checked this out & restarted my rails server, even created a new sequel lite db and could only see a subset of my data. Some pokemon with and without nicknames showed, but it was an incomplete set regardless. I didn't see any errors in my local log.

How better to test this?

Limeliz commented 8 years ago

@shinyuX: I think you forgot to commit the change of the size because it is not showing on github.

@YesThatAllen: add the edit manually. Go to the Change tab of this PR and add the new likes manually to your files. There are only three edit so it will go fast. That is how i did it because I am terrible at git and it works for me.

The nickname data is already store in the DB. This change just shows it on the cards page. If I remember correctlytheh were already showing on another page, Top100 I think.

shinyuX commented 8 years ago

That's really odd, I can assure you the card size modification could be seen here. Can someone checkout this and confirm it's ok for him/her/it ?