dpilger26 / NumCpp

C++ implementation of the Python Numpy library
https://dpilger26.github.io/NumCpp
MIT License
3.59k stars 554 forks source link

Get NumCpp version fail #179

Closed 11hwu2 closed 1 year ago

11hwu2 commented 1 year ago

When I git clone lastest NumCpp commit and build on raspberry pi,get this:

pi@fluiddpi:~/wh21/NumCpp/build $ cmake ../
-- Compiling with C++ standard: 17
-- Found Boost: /usr/local/lib/cmake/Boost-1.72.0/BoostConfig.cmake (found suitable version "1.72.0", minimum required is "1.68.0")
-- Found version file: /home/pi/wh21/NumCpp/include/NumCpp/Core/Internal/Version.hpp
-- The CXX compiler identification is GNU 8.3.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building NumCpp version 0.0.0
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pi/wh21/NumCpp/build

It seems issue in include/NumCpp/Core/Internal/Version.hpp

#pragma once

namespace nc
{
    constexpr char VERSION[] = "2.8."; ///< Current NumCpp version number
} // namespace nc

So I checkout a new branch on tag Version_2.8.0, it's ok.

pi@fluiddpi:~/wh21/NumCpp/build $ cmake ../
-- Compiling with C++ standard: 17
-- Found Boost: /usr/local/lib/cmake/Boost-1.72.0/BoostConfig.cmake (found suitable version "1.72.0", minimum required is "1.68.0")
-- Found version file: /home/pi/wh21/NumCpp/include/NumCpp/Core/Internal/Version.hpp
-- The CXX compiler identification is GNU 8.3.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building NumCpp version 2.8.0
-- Configuring ReadMe
-- Found Boost: /usr/local/lib/cmake/Boost-1.72.0/BoostConfig.cmake (found suitable version "1.72.0", minimum required is "1.68.0") found components: system filesystem
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pi/wh21/NumCpp/build
dpilger26 commented 1 year ago

Thanks for pointing this out. I've just merged and released version 2.9.0 so this is fixed now anyway.