search

dpilger26 / NumCpp

C++ implementation of the Python Numpy library
https://dpilger26.github.io/NumCpp
MIT License
3.51k stars 548 forks source link

Allow NUMCPP_NO_USE_BOOST to build examples without error #190

Closed bp-kelley closed 1 year ago

bp-kelley commented 1 year ago

Great Library! This is a small fix to allow the following to compile with errors.

cmake -D NUMCPP_NO_USE_BOOST=ON -D BUILD_EXAMPLE_ALL=ON .

It simply turns off the ReadMe example when NUMCPP_NO_USE_BOOST=ON

Again, thanks for the nice work.

dpilger26 commented 1 year ago

Since the minimum required C++ version is now C++17, I removed boost/filesystem from the ReadMe example and replaced it with <filesystem> instead. This removes boost as a dependency to the ReadMe example and makes this PR OBE. Update will be merged in the next release.